[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 09:39:47 PDT 2024


================
@@ -83,7 +83,11 @@ ModuleSP DynamicLoader::GetTargetExecutable() {
       ModuleSpec module_spec(executable->GetFileSpec(),
                              executable->GetArchitecture());
       auto module_sp = std::make_shared<Module>(module_spec);
-
+      // If we're a coredump and we already have a main executable, we don't
+      // need to reload the module list that target already has
----------------
Jlalond wrote:

In the Testcase in MinidumpUUID, the one module which has a matching filename that isn't an actual match needs this check in order to work.

The situation is the DYLD will itself create a stub depending on some conditions, but this is after the process has already made a stub. So we need some way for the CoreProcess to supercede the dynamic loader clearing all loaded modules again, and so I added this

https://github.com/llvm/llvm-project/pull/109477


More information about the lldb-commits mailing list