[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

[David Spickett via lldb-commits]

DavidSpickett wrote:

I suspect a missing unsupported annotation:
```
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_FakeAttachedRunInTerminalLauncherWithInvalidProgram (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_FakeAttachedRunInTerminalLauncherWithValidProgram (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_NonAttachedRunInTerminalLauncher (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_missingArgInRunInTerminalLauncher (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_runInTerminal (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_runInTerminalInvalidTarget (TestDAP_runInTerminal.TestDAP_runInTerminal) (skipping due to the following parameter(s): architecture) 
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_runInTerminalWithObjectEnv (TestDAP_runInTerminal.TestDAP_runInTerminal)
======================================================================
FAIL: test_runInTerminalWithObjectEnv (TestDAP_runInTerminal.TestDAP_runInTerminal)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py", line 101, in test_runInTerminalWithObjectEnv
    self.build_and_launch(program, runInTerminal=True, env={"FOO": "BAR"})
  File "/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 485, in build_and_launch
    return self.launch(
  File "/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 442, in launch
    self.assertTrue(
AssertionError: False is not true : launch failed (Failed to attach to the target process. Timed out trying to get messages from the runInTerminal launcher)
Config=arm-/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang
----------------------------------------------------------------------
Ran 8 tests in 1.686s

FAILED (failures=1, skipped=7)
Timed out trying to get messages from the debug adaptor
```
I've gone ahead and added the same skip https://github.com/llvm/llvm-project/commit/98c9c1a4d2d4fc41b34f73e4630de435c9c0c396.

Though I am curious why these tests are so x86 specific. Windows too, but we don't see a failure on Windows on Arm (unless somehow x86 emulation is making it work).

https://github.com/llvm/llvm-project/pull/106919