[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

[Pavel Labath via lldb-commits]

https://github.com/labath commented:

It's not clear to me what's up with the idea of moving the saving code to the dynamic loader plugin. Is that something you plan to work on?

The main thing that bothers me is the `AddLinkMapSections` function. Although it superficially generic, it uses the `GetImageInfoAddress`, which is only implemented by ObjectFileELF, and only called from the elf-core and posix-dyld plugins (i.e. code which already knows its dealing with elf object files), so I doubt it will be useful elsewhere. Even the name "link map" is very elf-specific, as there's nothing quite like that in other platforms/object file formats.

https://github.com/llvm/llvm-project/pull/109477