[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 8 01:24:47 PDT 2024
labath wrote:
At least back when I was looking at this problem (5+ years ago), memory mapping was the key -- I was not able to delete the process if the file was mapped -- regardless of the open flags. That said, [this comment](https://github.com/llvm/llvm-project/blob/4d218caa7716743061e8d34d61b2181c94b16440/llvm/lib/Support/Windows/Path.inc#L921C1-L925C20) seems to indicate this might be possible (though it may refer to FILE_FLAG_DELETE_ON_CLOSE rather then an separate delete operation), so :shrug:
Either way, I think this change is fine, as we don't really want to enforce that the file *can't* be deleted if the source cache setting is "true".
https://github.com/llvm/llvm-project/pull/111237
More information about the lldb-commits
mailing list