[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

[Pavel Labath via lldb-commits]

================
@@ -556,6 +559,24 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch) {
   si_signo = data.GetU32(&offset);
   si_errno = data.GetU32(&offset);
   si_code = data.GetU32(&offset);
+  // 64b ELF have a 4 byte pad.
+  if (data.GetAddressByteSize() == 8)
+    offset += 4;
+  // Not every stop signal has a valid address, but that will get resolved in
+  // the unix_signals_sp->GetSignalDescription() call below.
+  if (unix_signals_sp->GetShouldStop(si_signo)) {
----------------
labath wrote:

`GetShouldStop` is called when determining whether we should automatically resume an application when it gets interrupted by a signal. Using it in a core file is.. unusual, as there is nothing to resume. What exactly are you trying to achieve here?

https://github.com/llvm/llvm-project/pull/110065