[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

[via lldb-commits]

================
@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) {
 }
 
 void CommandReturnObject::SetError(llvm::Error error) {
-  if (error)
+  // Retrieve any diagnostics.
+  error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error) {
----------------
jimingham wrote:

Why is this data structure called ExpressionErrorBase?  That's a clearly inappropriate name for errors in a generic CommandObject, and seeing it here is confusing.

https://github.com/llvm/llvm-project/pull/110901