[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

[Michael Buch via lldb-commits]

https://github.com/Michael137 commented:

I guess we're paying the cost of copying the entire list of module pointers (and removing an element) for one less `FindFunctions`/`FindSymbolsWithNameAndType` call. Probably fine? But it still feels a bit off having to do this (though as you demonstrated, baking it into the `FindFunctions` API has proven to be pretty hairy).

Why is it so expensive to perform consecutive lookups into the same module for the same name? Should that be perhaps where we should focus the performance investigation on? So users don't need to care about how many times we're doing the lookup?

But if others are ok with this tradeoff here, I don't want to further block this PR

https://github.com/llvm/llvm-project/pull/102835