[Lldb-commits] [lldb] [lldb][CMake] Add single target that runs libc++ tests (PR #110856)

via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 2 07:50:22 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Michael Buch (Michael137)

<details>
<summary>Changes</summary>

We've been increasing the coverage of libc++ LLDB tests in the pre-merge CI (see https://github.com/llvm/llvm-project/pull/110570). Unfortunately the tests are spread across different targets. It would be great if we had a single target that libc++ maintainers could run. And we would just add additional tests to that list on the LLDB side as needed.

This patch adds such target.

I'm not sure if there's a more idiomatic way of doing this in CMake (or maybe `lit`? using the `libc++` API test category?). But here's a first stab that does the right thing locally

---
Full diff: https://github.com/llvm/llvm-project/pull/110856.diff


1 Files Affected:

- (modified) lldb/test/CMakeLists.txt (+15) 


``````````diff
diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt
index 5ac474736eb63d..656f9a1727b316 100644
--- a/lldb/test/CMakeLists.txt
+++ b/lldb/test/CMakeLists.txt
@@ -267,6 +267,21 @@ add_lit_testsuite(check-lldb "Running lldb lit test suite"
     lldb-shell-test-deps
     lldb-unit-test-deps)
 
+# This target covers all targets that are tied to implementation details
+# of libc++, intended to be run by the libc++ pre-merge CI.
+add_lit_testsuite(check-lldb-libcxx-integration "Running lldb libc++ support test suite"
+  ${CMAKE_CURRENT_BINARY_DIR}
+  EXCLUDE_FROM_CHECK_ALL
+  DEPENDS
+    check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx
+    check-lldb-api-functionalities-data-formatter-data-formatter-stl-generic
+    check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx-simulators
+    check-lldb-api-commands-expression-import-std-module
+    check-lldb-api-lang-cpp-std-function-step-into-callable
+    check-lldb-api-lang-cpp-std-function-recognizer
+    check-lldb-api-lang-cpp-std-invoke-recognizer
+)
+
 if(LLDB_BUILT_STANDALONE)
   # This has to happen *AFTER* add_lit_testsuite.
   if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/llvm-lit)

``````````

</details>


https://github.com/llvm/llvm-project/pull/110856


More information about the lldb-commits mailing list