[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 2 05:05:59 PDT 2024


labath wrote:

> > I don't like globals
> 
> Is this the only argument? 

No, it's not. You can find my second reason in the full text of my previous message. The third reason is that I think this is something that should be handled independenly of this (already larger that I'd like) patch.

> I don't like globals too. But no one suggested better solution w/o huge refactoring of MonitorProcessCallback.

You didn't ask for one either. Declaring it's [the only way](https://github.com/llvm/llvm-project/pull/104238#discussion_r1745282649) isn't the most traditional way of soliciting feedback. 

> 
> Updated. The child process will crash 50/50 at the end, but no one will see it. The problem will remain hidden. Removed `fixes #101475` in the description. I can create a separate patch after merging this PR.

:+1: 

I'm going to look at the patch now.

https://github.com/llvm/llvm-project/pull/104238


More information about the lldb-commits mailing list