[Lldb-commits] [lldb] [lldb] Add isConstant mode for FA locations (PR #110726)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 1 15:18:07 PDT 2024


================
@@ -2088,6 +2088,13 @@ bool RegisterContextUnwind::ReadFrameAddress(
     UnwindLogMsg("No suitable CFA found");
     break;
   }
+  case UnwindPlan::Row::FAValue::isConstant: {
+    address = fa.GetConstant();
+    if (abi_sp)
+      address = abi_sp->FixCodeAddress(address);
----------------
jasonmolenda wrote:

We prefer people call `Process::FixDataAddress()` these days, a method which gets the ABI and runs the method.  (this is the address on the stack, so FixDataAddress is the correct method).  Yeah the code above at line 2051 should be doing the same thing, I know you were only copying it here.

https://github.com/llvm/llvm-project/pull/110726


More information about the lldb-commits mailing list