[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for thread stacks (PR #110579)

[Henrik G. Olsson via lldb-commits]

hnrklssn wrote:

This is my main suspect for this failure in Green Dragon: https://green.lab.llvm.org/job/llvm.org/job/llvm-coverage/64/consoleFull

Relevant test output:
```
AIL: test_with_run_command_libcpp_dsym (TestDataFormatterGenericOptional.GenericOptionalDataFormatterTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1769, in test_method
    return attrvalue(self)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 148, in wrapper
    return func(*args, **kwargs)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 148, in wrapper
    return func(*args, **kwargs)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py", line 103, in test_with_run_command_libcpp
    self.do_test_with_run_command(USE_LIBCPP)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py", line 59, in do_test_with_run_command
    self.expect(
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2475, in expect
    self.fail(log_msg)
AssertionError: Ran command:
"frame var numbers"

Got output:
(optional_int_vect) numbers =  Has Value=true  {
  Value = {
    __begin_ = 0x00006000013d4000
    __end_ = 0x00006000013d4010
    __cap_ = 0x00006000013d4010
    __padding1_781_ = (__padding_ = "\U00000001\0\0\0\0\0\0\0*\0\0\0*\0\0\0\U00000001\0\0\0*\0\0\0*\0\0\0\U00000001\U0000007f\0\0\0\U00000014B\xb5\0\U0000007f\0\0p\U00000013B\U00000001\0\0\0\0\U00000001\0\0\0\U00000002\0\0\0\U00000003\0\0\0\U00000004")
    __alloc_ = {}
    __padding2_781_ = (__padding_ = "\U00000001\0\0\0\0\0\0\0*\0\0\0*\0\0\0\U00000001\0\0\0*\0\0\0*\0\0\0\U00000001\U0000007f\0\0\0\U00000014B\xb5\0\U0000007f\0\0p\U00000013B\U00000001\0\0\0\0\U00000001\0\0\0\U00000002\0\0\0\U00000003\0\0\0\U00000004")
  }
}

Expecting sub string: "(optional_int_vect) numbers =  Has Value=true  {" (was found)
Expecting sub string: "Value = size=4 {" (was not found)
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/lldb-build/bin/clang
======================================================================
FAIL: test_with_run_command_libcpp_dwarf (TestDataFormatterGenericOptional.GenericOptionalDataFormatterTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1769, in test_method
    return attrvalue(self)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 148, in wrapper
    return func(*args, **kwargs)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 148, in wrapper
    return func(*args, **kwargs)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py", line 103, in test_with_run_command_libcpp
    self.do_test_with_run_command(USE_LIBCPP)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py", line 59, in do_test_with_run_command
    self.expect(
  File "/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2475, in expect
    self.fail(log_msg)
AssertionError: Ran command:
"frame var numbers"

Got output:
(optional_int_vect) numbers =  Has Value=true  {
  Value = {
    __begin_ = 0x0000600003704000
    __end_ = 0x0000600003704010
    __cap_ = 0x0000600003704010
    __padding1_781_ = (__padding_ = "\U00000001\0\0\0\0\0\0\0*\0\0\0*\0\0\0\U00000001\0\0\0*\0\0\0*\0\0\0\U00000001\U0000007f\0\0\0\xc3\U00000010\xbc\0\U0000007f\0\0`\xc3\U00000010\U00000001\0\0\0\0\U00000001\0\0\0\U00000002\0\0\0\U00000003\0\0\0\U00000004")
    __alloc_ = {}
    __padding2_781_ = (__padding_ = "\U00000001\0\0\0\0\0\0\0*\0\0\0*\0\0\0\U00000001\0\0\0*\0\0\0*\0\0\0\U00000001\U0000007f\0\0\0\xc3\U00000010\xbc\0\U0000007f\0\0`\xc3\U00000010\U00000001\0\0\0\0\U00000001\0\0\0\U00000002\0\0\0\U00000003\0\0\0\U00000004")
  }
}

Expecting sub string: "(optional_int_vect) numbers =  Has Value=true  {" (was found)
Expecting sub string: "Value = size=4 {" (was not found)
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/llvm-coverage/lldb-build/bin/clang
----------------------------------------------------------------------
Ran 6 tests in 13.814s

FAILED (failures=2, skipped=4)
```

https://github.com/llvm/llvm-project/pull/110579