[Lldb-commits] [lldb] [lldb] Unify implementation of CommandReturnObject::SetError(NFC) (PR #110707)

[via lldb-commits]

jimingham wrote:

`SetError(Status error, const char* fallback_error_string)` was a badly named API.  What it actually does is APPEND either the error string in the incoming `error`, or if that had no error string, the `fallback_error_string`, to whatever was already in the command error.
So far as I can tell, there are no internal uses of this fallback_error_string (I removed that argument from the API and lldb still compiles.)  However, we made an equally poorly named SBCommandReturnObject API that does take this string.
So this change does change the behavior of this quite poorly named API which I bet no one was using for that purpose, but still...

https://github.com/llvm/llvm-project/pull/110707