[Lldb-commits] [lldb] [lldb] Add isConstant mode for FA locations (PR #110726)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 1 12:17:35 PDT 2024


================
@@ -2088,6 +2088,12 @@ bool RegisterContextUnwind::ReadFrameAddress(
     UnwindLogMsg("No suitable CFA found");
     break;
   }
+  case UnwindPlan::Row::FAValue::isConstant: {
+    address = fa.GetConstant();
+    address = abi_sp->FixCodeAddress(address);
----------------
felipepiovezan wrote:

@jasonmolenda  I see a few other places in this file calling the function above (`FixCodeAddress`). But there are many other places that just take addresses and use them as is to do things like `Process:ReadMemory`... it makes me wonder whether we should audit those uses.

https://github.com/llvm/llvm-project/pull/110726


More information about the lldb-commits mailing list