[Lldb-commits] [lldb] 3eaaf7c - [lldb][AArch64] Fix crash loading core files on 32 bit systems

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2024-09-26T12:06:23Z
New Revision: 3eaaf7c4d062976901c79b523e9f3cc606943119

URL: https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119
DIFF: https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119.diff

LOG: [lldb][AArch64] Fix crash loading core files on 32 bit systems

https://github.com/llvm/llvm-project/pull/109934 added FPMR which
uses a bit in hwcaps greater than 31. So it marked the 1 with UL
which is fine on 64 bit systems but for 32 bit UL is 4 bytes.

Use ULL so we aren't invoking undefined behaviour.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/Utility/RegisterFlagsDetector_arm64.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/Utility/RegisterFlagsDetector_arm64.cpp b/lldb/source/Plugins/Process/Utility/RegisterFlagsDetector_arm64.cpp
index 72ced42a158233..9f82c935c0e7ed 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterFlagsDetector_arm64.cpp
+++ b/lldb/source/Plugins/Process/Utility/RegisterFlagsDetector_arm64.cpp
@@ -23,7 +23,7 @@
 #define HWCAP2_AFP (1ULL << 20)
 #define HWCAP2_SME (1ULL << 23)
 #define HWCAP2_EBF16 (1ULL << 32)
-#define HWCAP2_FPMR (1UL << 48)
+#define HWCAP2_FPMR (1ULL << 48)
 
 using namespace lldb_private;