[Lldb-commits] [lldb] 706821b - [lldb][test] Skip TestConcurrentVFork on all Linux

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2024-09-25T10:08:10+01:00
New Revision: 706821ba8ff9db829252581dd12d8c5ee2e7b3f0

URL: https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0
DIFF: https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0.diff

LOG: [lldb][test] Skip TestConcurrentVFork on all Linux

And given that it is only for Linux - effectively skip it,
but in a way where we don't forget that it's Linux only.

See https://github.com/llvm/llvm-project/issues/85084.

This test times out on occasion on Arm, AArch64 and X86 Linux,
which I saw just today in a buildkite build. Causing a failure that
is 1. confusing because the PR wasn't for LLDB and 2. annoying
to find in the giant log file (which isn't the test's fault,
but it adds to the overhead).

It's probably important to have this test running somewhere but
right now it's causing too much noise to do so.

Added: 
    

Modified: 
    lldb/test/API/functionalities/fork/concurrent_vfork/TestConcurrentVFork.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/fork/concurrent_vfork/TestConcurrentVFork.py b/lldb/test/API/functionalities/fork/concurrent_vfork/TestConcurrentVFork.py
index dd9500c186b2c8..3b5efb834b1626 100644
--- a/lldb/test/API/functionalities/fork/concurrent_vfork/TestConcurrentVFork.py
+++ b/lldb/test/API/functionalities/fork/concurrent_vfork/TestConcurrentVFork.py
@@ -49,7 +49,7 @@ def follow_child_helper(self, use_fork, call_exec):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_parent_vfork_no_exec(self):
         """
         Make sure that debugging concurrent vfork() from multiple threads won't crash lldb during follow-parent.
@@ -59,7 +59,7 @@ def test_follow_parent_vfork_no_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_parent_fork_no_exec(self):
         """
         Make sure that debugging concurrent fork() from multiple threads won't crash lldb during follow-parent.
@@ -69,7 +69,7 @@ def test_follow_parent_fork_no_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_parent_vfork_call_exec(self):
         """
         Make sure that debugging concurrent vfork() from multiple threads won't crash lldb during follow-parent.
@@ -79,7 +79,7 @@ def test_follow_parent_vfork_call_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_parent_fork_call_exec(self):
         """
         Make sure that debugging concurrent vfork() from multiple threads won't crash lldb during follow-parent.
@@ -89,7 +89,7 @@ def test_follow_parent_fork_call_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_child_vfork_no_exec(self):
         """
         Make sure that debugging concurrent vfork() from multiple threads won't crash lldb during follow-child.
@@ -99,7 +99,7 @@ def test_follow_child_vfork_no_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_child_fork_no_exec(self):
         """
         Make sure that debugging concurrent fork() from multiple threads won't crash lldb during follow-child.
@@ -109,7 +109,7 @@ def test_follow_child_fork_no_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_child_vfork_call_exec(self):
         """
         Make sure that debugging concurrent vfork() from multiple threads won't crash lldb during follow-child.
@@ -119,7 +119,7 @@ def test_follow_child_vfork_call_exec(self):
 
     @skipUnlessPlatform(["linux"])
     # https://github.com/llvm/llvm-project/issues/85084.
-    @skipIf(oslist=["linux"], archs=["aarch64", "arm"])
+    @skipIf(oslist=["linux"])
     def test_follow_child_fork_call_exec(self):
         """
         Make sure that debugging concurrent fork() from multiple threads won't crash lldb during follow-child.