[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

[via lldb-commits]

================
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript(
   result.SetStatus(eReturnStatusSuccessFinishNoResult);
   result.AppendMessageWithFormat("Session's transcripts saved to %s\n",
                                  output_file->c_str());
+  if (!GetSaveTranscript())
+    result.AppendError("Note: the setting interpreter.save-transcript is set to false, so the transcript might not have been recorded.");
----------------
jeffreytan81 wrote:

Hmm, one would argue that when `interpreter.save-transcript` is set to false, it should clear any internal buffer because the name `interpreter.save-transcript = false` implies it should not save transcript. 

For the current behavior, `interpreter.save-transcript` should be renamed to "stop-record-commands" or something like this. 

Not say it is important or I care though. 

https://github.com/llvm/llvm-project/pull/109020