[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

[Adrian Vogelsgesang via lldb-commits]

vogelsgesang wrote:

> However, with these new "hiding frame" recognizers, we are using the frame hiding recognizers to handle "step out past hidden frames".  So if - as was done in the original implementation - we're determining this during execution control, its hard to see how we can avoid running these recognizers all the time.  That argues for not allowing unbounded backtracing in recognizers.

Good point, that's something which probably should be changed... CC @adrian-prantl 

> [...] So it would be better to make this an explicit gesture somehow.

`StackFrameList::GetSelectedFrameIndex` already takes a parameter `select_most_relevant` which enables the frame recognizers only for user-visible stops. At least from a cursory look over all its callers, it looks like what you are proposing?

(Not sure if I missed anything, though. Still new to the lldb code base...)


https://github.com/llvm/llvm-project/pull/109594