[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)
Dmitrii Galimzianov via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 24 02:44:27 PDT 2024
DmT021 wrote:
@clayborg @Michael137 I've reverted the changes here and rewrote this patch pretty much like it was originally presented with a slightly different order of operation. The only change is in the `IRExecutionUnit::FindInSymbols` function and the order of lookup is described in the comment [here](https://github.com/llvm/llvm-project/pull/102835/files#diff-717a850c4315286c025e2739ebe9dacbf27e626b7679c72479b05c996d721112R799). If you don't mind let's merge this variant.
In my opinion, [the variant with lambda](https://github.com/llvm/llvm-project/commit/c647b26ad534bb998063722f930ddd07162bfee7) is too complex for a little win and I'm afraid future changes in this logic will be even more complicated.
https://github.com/llvm/llvm-project/pull/102835
More information about the lldb-commits
mailing list