[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

[Dmitry Vasilyev via lldb-commits]

slydiman wrote:

> But do both of those callers need the "optional launch" functionality? AIUI, it's only the Handle_qLaunchGDBServer that does, and the code in lldb-platform.cpp should launch a server unconditionally.

We can launch gdbserver with tcp protocol only after accepting the connection.
lldb-platform.cpp calls GDBRemoteCommunicationServerPlatform::LaunchGDBServer() when
1. Accept the gdb connection (fd is known).
2. At the beginning if additional parameters provided after `--`. fd=kInvalidFD. It is a `pending` GdbServer.

https://github.com/llvm/llvm-project/pull/104238