[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

[Adrian Vogelsgesang via lldb-commits]

================
@@ -1 +0,0 @@
-objc
----------------
vogelsgesang wrote:

The intended test coverage of this test case seems to be to test the frame recognizers as indicated by the file path.
Making making it run also on non-Mac platforms, we are hence gaining test coverage on other systems.

There is no comment I could find which states that frame recognizers work differently for Objective-C. As such, I would expect any test coverage for Objective-C to be incidental, and would expect the Objective-C support to be tested in-depth by some other test cases.

I am used to the guideline "It's ok to remove incidental test coverage. If the test coverage was worthwhile, there should have been a comment added as part of adding the test" from other projects. But that's based on my experience with how other projects treat their test suites. Not sure if this also applies to LLDB? 

https://github.com/llvm/llvm-project/pull/109219