[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

[David Spickett via lldb-commits]

DavidSpickett wrote:

Output from the 2 failures:
```
FAIL: test_file_fail (TestGDBRemotePlatformFile.TestGDBRemotePlatformFile.test_file_fail)

    Test mocked failures of remote operations

----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\gdb_remote_client\TestGDBRemotePlatformFile.py", line 53, in test_file_fail
    self.match(
  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\lldbtest.py", line 2092, in match
    self.assertTrue(
AssertionError: False is not true : 'platform file open /some/file.txt -v 0755' returned unexpected result, got 'error: function not supported'

Config=aarch64-C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe

----------------------------------------------------------------------

******************** TEST 'lldb-unit :: Utility/./UtilityTests.exe/1/8' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\unittests\Utility\.\UtilityTests.exe-lldb-unit-4868-1-8.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=8 GTEST_SHARD_INDEX=1 C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\unittests\Utility\.\UtilityTests.exe
--

Script:
--
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\unittests\Utility\.\UtilityTests.exe --gtest_filter=StatusTest.ErrorWin32
--
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp(86): error: Expected equality of these values:
  0
    Which is: NULL
  success.AsCString()
    Which is: "The operation completed successfully. "

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp(87): error: Value of: success.ToError()
  Actual: true
Expected: false

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp(88): error: Value of: success.Success()
  Actual: false
Expected: true


C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp:86
Expected equality of these values:
  0
    Which is: NULL
  success.AsCString()
    Which is: "The operation completed successfully. "

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp:87
Value of: success.ToError()
  Actual: true
Expected: false

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\StatusTest.cpp:88
Value of: success.Success()
  Actual: false
Expected: true
```


https://github.com/llvm/llvm-project/pull/106774