[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

[David Spickett via lldb-commits]

DavidSpickett wrote:

This is failing on Windows because we use an error code that means there was no error in one of the tests in `lldb/unittests/Utility/StatusTest.cpp`:
```
  auto success = Status(NO_ERROR, ErrorType::eErrorTypeWin32);
  EXPECT_STREQ(NULL, success.AsCString());
  EXPECT_FALSE(success.ToError());
  EXPECT_TRUE(success.Success());
```
This now marks the status as a failure.

I would be tempted to remove the test but given that this is a Windows defined value, all sorts of APIs might return it and we don't want to be marking lots of things as failures when they aren't.

https://github.com/llvm/llvm-project/pull/106774