[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 20 06:06:32 PDT 2024


labath wrote:

> > I'm also not sure where's the "<pool_entry_range => NameEntry> mapping table" you mention in the description. Could you point me to it?
> 
> @labath, that is the first prototype I tried, but benchmark shows it did not improve any performance because the time to build this mapping offsets any query gain later so this PR did not use it and uses the second idea by searching parent entry's matching names which is implemented in this PR.

Okay, that explains why I couldn't find it, but then I guess the patch description is out of date, as it still contains this:

> The new implementation minimizes the need to touch DWO files by employing two strategies:
> -    Build a <pool_entry_range => NameEntry> mapping table (built lazily as needed), allowing us to check the name of the parent entry.

Can you update it to reflect the current state of the patch (you may choose to keep this in some "alternatives considered" section, but I wouldn't say that's necessary)?

https://github.com/llvm/llvm-project/pull/108907


More information about the lldb-commits mailing list