[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

Wed Sep 18 14:58:12 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/5479

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
30.949 [870/8/41] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/HostProcessPosix.cpp.o
31.619 [869/8/42] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/LockFilePosix.cpp.o
32.578 [868/8/43] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/ConnectionFileDescriptorPosix.cpp.o
33.587 [867/8/44] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/linux/AbstractSocket.cpp.o
33.702 [866/8/45] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
34.561 [865/8/46] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/MainLoopPosix.cpp.o
35.570 [864/8/47] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/PipePosix.cpp.o
35.601 [863/8/48] Generating VCSVersion.inc
36.510 [862/8/49] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/StringExtractorGDBRemote.cpp.o
36.578 [861/8/50] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o
FAILED: tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source/Utility -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/../clang/include -I/usr/include/libxml2 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o -MF tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o.d -o tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o -c /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility/Status.cpp
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility/Status.cpp:51:15: error: looser throw specifier for ‘virtual const char* {anonymous}::LLDBGenericCategory::name() const’
   51 |   const char *name() const override { return "LLDBGenericCategory"; }
      |               ^~~~
In file included from /usr/include/c++/9/bits/ios_base.h:46,
                 from /usr/include/c++/9/ios:42,
                 from /usr/include/c++/9/ostream:38,
                 from /usr/include/c++/9/iterator:64,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/ADL.h:13,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/iterator_range.h:21,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/StringRef.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include/lldb/Utility/Status.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility/Status.cpp:9:
/usr/include/c++/9/system_error:85:5: note: overridden function is ‘virtual const char* std::_V2::error_category::name() const noexcept’
   85 |     name() const noexcept = 0;
      |     ^~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility/Status.cpp:61:15: error: looser throw specifier for ‘virtual const char* {anonymous}::ExpressionCategory::name() const’
   61 |   const char *name() const override { return "LLDBExpressionCategory"; }
      |               ^~~~
In file included from /usr/include/c++/9/bits/ios_base.h:46,
                 from /usr/include/c++/9/ios:42,
                 from /usr/include/c++/9/ostream:38,
                 from /usr/include/c++/9/iterator:64,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/ADL.h:13,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/iterator_range.h:21,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include/llvm/ADT/StringRef.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include/lldb/Utility/Status.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Utility/Status.cpp:9:
/usr/include/c++/9/system_error:85:5: note: overridden function is ‘virtual const char* std::_V2::error_category::name() const noexcept’
   85 |     name() const noexcept = 0;
      |     ^~~~
36.700 [861/7/51] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp: In member function ‘void llvm::AsmPrinter::emitJumpTableSizesSection(const llvm::MachineJumpTableInfo*, const llvm::Function&) const’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2823:31: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
 2823 |     int Flags = F.hasComdat() ? ELF::SHF_GROUP : 0;
      |                 ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
37.093 [861/6/52] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/ProcessLauncherPosixFork.cpp.o
37.358 [861/5/53] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/linux/HostInfoLinux.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/106774