[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 18 09:55:27 PDT 2024


================
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript(
   result.SetStatus(eReturnStatusSuccessFinishNoResult);
   result.AppendMessageWithFormat("Session's transcripts saved to %s\n",
                                  output_file->c_str());
+  if (!GetSaveTranscript())
+    result.AppendError("Note: the setting interpreter.save-transcript is set to false, so the transcript might not have been recorded.");
----------------
medismailben wrote:

We should do this at the beginning of the function, before doing the work and return early if `save-transcript` is disabled.

https://github.com/llvm/llvm-project/pull/109020


More information about the lldb-commits mailing list