[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

[via lldb-commits]

================
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript(
   result.SetStatus(eReturnStatusSuccessFinishNoResult);
   result.AppendMessageWithFormat("Session's transcripts saved to %s\n",
                                  output_file->c_str());
+  if (!GetSaveTranscript())
+    result.AppendError("Note: the setting interpreter.save-transcript is set to false, so the transcript might not have been recorded.");
----------------
jeffreytan81 wrote:

I am not sure why we are using `might not` here. Since `GetSaveTranscript()` is false, isn't the transcript definitely won't be saved? Maybe rewording to: 

```
Note: the interpreter.save-transcript setting is disabled (false), so the transcript will not be saved.
```

https://github.com/llvm/llvm-project/pull/109020