[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 18 08:11:37 PDT 2024


dlav-sc wrote:

> I expect these will be at risk of diverging if done separately

Your concern is reasonable, I see this stuff in two places: `DisassemblerLLVMC::DisassemblerLLVMC` and `GetValObjFromFPRegs` in `ABISysV_riscv.cpp` (also `ObjectFileELF::GetSectionHeaderInfo` works with float flags, but it just parses elf header and takes features from there).

> I wonder if our ArchSpec should have a method to get the clang feature flags.

I've expected that `CompilerInstance` (`m_compiler`) has this method, because clang should get features somehow and as I know, it uses march for this purposes, but I couldn't find this functionality. As for lldb, maybe it can be useful to obtain features flags from `ArchSpec`, but I think this should be done in a separate PR, if you don't mind.

https://github.com/llvm/llvm-project/pull/99336


More information about the lldb-commits mailing list