[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

[David Spickett via lldb-commits]

DavidSpickett wrote:

I've disabled this on Windows for now but please address the issue generally.

Testing memory region overlaps is tricky. I did it for memory tagging by hoping that the kernel would allocate pages in the right order, which worked for at least simulated systems. Pavel recently added `lldb/test/API/functionalities/memory/holes/main.cpp` which has Windows and Linux code for allocating regions.

It's tricky though, because you need to split a region here instead of making a gap. Maybe you can allocate a larger area, unmap part of it, then remap that part again.

If you don't have a Windows machine to do that on, I'm happy for the test to be Linux specific because:
* The functionality is pretty generic, if it works there, it'll work on Windows.
* I'm happy to add the Windows support code myself.

https://github.com/llvm/llvm-project/pull/104317