[Lldb-commits] [lldb] ab38ec9 - [lldb][lldb-dap] Disable read memory test on Windows

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2024-09-17T12:51:46Z
New Revision: ab38ec9ac312460e4f71c8ad3f50b9b5723469f6

URL: https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
DIFF: https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6.diff

LOG: [lldb][lldb-dap] Disable read memory test on Windows

This isn't strictly a Windows issue but for now it's the only bot
that was hit by this failure.

It can happen on Linux too but I expect we'll fix it and remove the
skip soon anyway.

Test was added in #104317.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py b/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
index 8bee70e50dcad9..3d8aaeda7f4b85 100644
--- a/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
+++ b/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
@@ -74,6 +74,10 @@ def test_memory_refs_set_variable(self):
             ].keys(),
         )
 
+    # lldb-dap assumes that all reads will be within the same region. On Windows
+    # the target string is at the very start of a region so the -1 offset causes
+    # the read to only read from the previous region and only return 1 byte.
+    @skipIfWindows
     def test_readMemory(self):
         """
         Tests the 'readMemory' request