[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

Thanks so much for putting together the patch for this.  Yeah enabling these registers only when the thread flavor is available is not that simple, and I don't think the consequence of including them with zero values in all cases is bad one.  Most general users will not be aware of what these registers indicate and ignore the 0's, and those people who are working on code where they are important, will see values for them, it seems fine to me.  I played around on an intel mac and the only side effect was that you'll get an error message if you try to modify one of the new registers when the thread state is not supported -- not a big surprise.  (`DNBArchImplX86_64::SetRegisterValue` will return an error if the full_state flavor was unavailable earlier in the debug session)

Do you have the permissions to merge this PR yourself?  I can do it if not.

https://github.com/llvm/llvm-project/pull/108663