[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 16 08:25:12 PDT 2024


================
@@ -78,7 +78,7 @@ bool CommandObjectThreadTraceStartIntelPT::DoExecuteOnThreads(
     llvm::ArrayRef<lldb::tid_t> tids) {
   if (Error err = m_trace.Start(tids, m_options.m_ipt_trace_size,
                                 m_options.m_enable_tsc, m_options.m_psb_period))
-    result.SetError(Status(std::move(err)));
+    result.SetError(Status::FromError(std::move(err)));
----------------
walter-erquinigo wrote:

just make sure that you really need to invoke std::move. It's possible that the compiler can do that on its own and that you don't need the explicit std::move

https://github.com/llvm/llvm-project/pull/108719


More information about the lldb-commits mailing list