[Lldb-commits] [lldb] [lldb] Nits on uses of llvm::raw_string_ostream (NFC) (PR #108745)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Sun Sep 15 20:58:50 PDT 2024


https://github.com/JDevlieghere approved this pull request.

Okay this is safe because after 65b13610a5226b84889b923bae884ba395ad084d, `raw_string_ostream` is always unbuffered so you (1) don't need to flush and (2) can use the underlying buffer directly. That makes sense. Please include that in your commit message. 

I would have split this up into two PRs/commits as the changes are related but can stand on their own, but it's not important enough to make you do more work. LGTM. 

https://github.com/llvm/llvm-project/pull/108745


More information about the lldb-commits mailing list