[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff b74e7792194d9a8a9ef32c7dc1ffcd205b299336 4453801c7d8abf7a6adfb7fae57ad9fa9d52a0c4 --extensions cpp,h -- lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.h lldb/tools/debugserver/source/MacOSX/x86_64/MachRegisterStatesX86_64.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp b/lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
index 286fd72267..6bc1055278 100644
--- a/lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+++ b/lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
@@ -184,10 +184,10 @@ kern_return_t DNBArchImplX86_64::GetGPRState(bool force) {
 #else
     mach_msg_type_number_t count = e_regSetWordSizeGPRFull;
     int flavor = __x86_64_THREAD_FULL_STATE;
-    m_state.SetError(
-        e_regSetGPR, Read,
-        ::thread_get_state(m_thread->MachPortNumber(), flavor,
-                           (thread_state_t)&m_state.context.gpr, &count));
+    m_state.SetError(e_regSetGPR, Read,
+                     ::thread_get_state(m_thread->MachPortNumber(), flavor,
+                                        (thread_state_t)&m_state.context.gpr,
+                                        &count));
 
     if (!m_state.GetError(e_regSetGPR, Read)) {
       m_state.hasFullGPRState = true;
@@ -195,10 +195,10 @@ kern_return_t DNBArchImplX86_64::GetGPRState(bool force) {
       m_state.hasFullGPRState = false;
       count = e_regSetWordSizeGPR;
       flavor = __x86_64_THREAD_STATE;
-      m_state.SetError(
-          e_regSetGPR, Read,
-          ::thread_get_state(m_thread->MachPortNumber(), flavor,
-                             (thread_state_t)&m_state.context.gpr, &count));
+      m_state.SetError(e_regSetGPR, Read,
+                       ::thread_get_state(m_thread->MachPortNumber(), flavor,
+                                          (thread_state_t)&m_state.context.gpr,
+                                          &count));
     }
     DNBLogThreadedIf(
         LOG_THREAD,
@@ -214,20 +214,19 @@ kern_return_t DNBArchImplX86_64::GetGPRState(bool force) {
         m_state.hasFullGPRState ? "full" : "non-full",
         m_state.hasFullGPRState ? __x86_64_THREAD_FULL_STATE
                                 : __x86_64_THREAD_STATE,
-        m_state.GetError(e_regSetGPR, Read),
-        m_state.context.gpr.__rax, m_state.context.gpr.__rbx,
-        m_state.context.gpr.__rcx, m_state.context.gpr.__rdx,
-        m_state.context.gpr.__rdi, m_state.context.gpr.__rsi,
-        m_state.context.gpr.__rbp, m_state.context.gpr.__rsp,
-        m_state.context.gpr.__r8, m_state.context.gpr.__r9,
-        m_state.context.gpr.__r10, m_state.context.gpr.__r11,
-        m_state.context.gpr.__r12, m_state.context.gpr.__r13,
-        m_state.context.gpr.__r14, m_state.context.gpr.__r15,
-        m_state.context.gpr.__rip, m_state.context.gpr.__rflags,
-        m_state.context.gpr.__cs, m_state.context.gpr.__fs,
-        m_state.context.gpr.__gs, m_state.context.gpr.__ds,
-        m_state.context.gpr.__es, m_state.context.gpr.__ss,
-        m_state.context.gpr.__gsbase );
+        m_state.GetError(e_regSetGPR, Read), m_state.context.gpr.__rax,
+        m_state.context.gpr.__rbx, m_state.context.gpr.__rcx,
+        m_state.context.gpr.__rdx, m_state.context.gpr.__rdi,
+        m_state.context.gpr.__rsi, m_state.context.gpr.__rbp,
+        m_state.context.gpr.__rsp, m_state.context.gpr.__r8,
+        m_state.context.gpr.__r9, m_state.context.gpr.__r10,
+        m_state.context.gpr.__r11, m_state.context.gpr.__r12,
+        m_state.context.gpr.__r13, m_state.context.gpr.__r14,
+        m_state.context.gpr.__r15, m_state.context.gpr.__rip,
+        m_state.context.gpr.__rflags, m_state.context.gpr.__cs,
+        m_state.context.gpr.__fs, m_state.context.gpr.__gs,
+        m_state.context.gpr.__ds, m_state.context.gpr.__es,
+        m_state.context.gpr.__ss, m_state.context.gpr.__gsbase);
 
 //      DNBLogThreadedIf (LOG_THREAD, "thread_get_state(0x%4.4x, %u, &gpr, %u)
 //      => 0x%8.8x"
@@ -478,13 +477,14 @@ kern_return_t DNBArchImplX86_64::SetGPRState() {
                   "(SetGPRState() for stop_count = %u)",
       m_thread->MachPortNumber(), kret, m_thread->Process()->StopCount());
 
-  m_state.SetError(e_regSetGPR, Write,
-                   ::thread_set_state(m_thread->MachPortNumber(),
-                                      m_state.hasFullGPRState ? __x86_64_THREAD_FULL_STATE
-                                                              : __x86_64_THREAD_STATE,
-                                      (thread_state_t)&m_state.context.gpr,
-                                      m_state.hasFullGPRState ? e_regSetWordSizeGPRFull
-                                                              : e_regSetWordSizeGPR));
+  m_state.SetError(
+      e_regSetGPR, Write,
+      ::thread_set_state(m_thread->MachPortNumber(),
+                         m_state.hasFullGPRState ? __x86_64_THREAD_FULL_STATE
+                                                 : __x86_64_THREAD_STATE,
+                         (thread_state_t)&m_state.context.gpr,
+                         m_state.hasFullGPRState ? e_regSetWordSizeGPRFull
+                                                 : e_regSetWordSizeGPR));
   DNBLogThreadedIf(
       LOG_THREAD,
       "::thread_set_state (0x%4.4x, %u, &gpr, %u) => 0x%8.8x"

``````````

</details>


https://github.com/llvm/llvm-project/pull/108663