[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

[Jacob Lalonde via lldb-commits]

================
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
   return 0;
 }
 
+struct SaveCoreRequest {
+  SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+  ~SaveCoreRequest() {
+    if (!m_success)
+      m_builder.DeleteFile();
----------------
Jlalond wrote:

I'll have to get the patch, it's one of my SBSaveCore API changes, but we now print the error when Plugin Manager returns, we could print twice, one specific for minidump

https://github.com/llvm/llvm-project/pull/108259