[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

[via lldb-commits]

jimingham wrote:

You also have to be careful when treating Errors in ValueObjects, since it is not always the case that a ValueObject that returns `GetError().Success() == true` on one stop will return that when the program is allowed to run.  For instance, the ValueObject for a local variable might have an error because it is not available at the current PC due to optimization, but it will be when you step again.  So an error state doesn't mean "discard me".

To be clear, I'm have no problem with rationalizing the error handling for ValueObjects, but we need to have a higher level plan first, I don't think going in piecemeal like this is going to be productive.

https://github.com/llvm/llvm-project/pull/106831