[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

Martin Storsjö via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 11 22:46:12 PDT 2024


mstorsjo wrote:

This broke building in mingw configurations, and possibly a few others as well.

The `ReportWarning` function takes a pointer to a `std::once_flag`, while this is passing it with a `llvm::once_flag`. In many configurations, these are the same type, but in a couple ones, they're not.

LLDB seems to be using a mixture of `std::once_flag` and `llvm::once_flag` throughout, with nontrivial numbers of both, so there's no one obvious preferred way to go here... Or should `ReportWarning` be extended to accept either kinds of flags, until the implementation is settled on either of them?

https://github.com/llvm/llvm-project/pull/107968


More information about the lldb-commits mailing list