[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 11 13:56:42 PDT 2024
adrian-prantl wrote:
> > Status is already extensively unittested.
>
> The fact that you were able to pull this switch off without changing a single line of test code tells me otherwise. Surely there is _some_ new functionality being added here.
That's *why* the implementation has all these quirky details :-)
>
> > Is there something you feel is missing?
>
> For example, the value of GetError()/GetType() for multi-error objects. And the ability to copy an ErrorInfo object and make sure that the copy preserves its type and content. Maybe there's more, but these are the most obvious new/changed behaviors of the class.
I'll add a test for that.
https://github.com/llvm/llvm-project/pull/106774
More information about the lldb-commits
mailing list