[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)
Miro Bucko via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 11 11:05:33 PDT 2024
================
@@ -450,6 +450,8 @@ class RangeDataVector {
void Append(const Entry &entry) { m_entries.emplace_back(entry); }
+ void Append(B &&b, S &&s, T &&t) { m_entries.emplace_back(Entry(b, s, t)); }
----------------
mbucko wrote:
why not just name then base, size, data? Then the reader doesn't have to read the function contract. Also, would be curious what the guideline says about single letter naming for variables.
https://github.com/llvm/llvm-project/pull/107937
More information about the lldb-commits
mailing list