[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)
via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 11 10:48:28 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 96b7c64b8a874584a9dad44bb8901904c14701c0 771be24eecb498cecf59062182ae680f33bdbb03 --extensions h,cpp -- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
index 7b7745b295..61444dd649 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
@@ -1219,13 +1219,12 @@ Status MinidumpFileBuilder::DumpFile() {
return error;
}
-
void MinidumpFileBuilder::DeleteFile() {
Log *log = GetLog(LLDBLog::Object);
if (m_core_file) {
Status error = m_core_file->Close();
- if (error.Fail())
+ if (error.Fail())
LLDB_LOGF(log, "Failed to close minidump file: %s", error.AsCString());
m_core_file.reset();
``````````
</details>
https://github.com/llvm/llvm-project/pull/108259
More information about the lldb-commits
mailing list