[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

[Omair Javaid via lldb-commits]

================
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
 
 NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-    : NativeRegisterContextWindows(native_thread,
-                                   CreateRegisterInfoInterface(target_arch)) {}
+    : NativeRegisterContextRegisterInfo(
+          native_thread, CreateRegisterInfoInterface(target_arch)) {
+  // Currently, there is no API to query the maximum supported hardware
+  // breakpoints and watchpoints on Windows. The values set below are based
----------------
omjavaid wrote:

I dont think a API exists to query hardware breakpoint or watchpoint resources. On x86_64 as well winnt.h definitions of hardware breakpoint and watchpoints are used.

winnt.h defined the max hardware breakpoints to be 8 however in reality only 6 can be used successfully. Also for watchpoints it defines 2 arm64 hardware watchpoints but in reality only 1 can be used.

https://github.com/llvm/llvm-project/pull/108072