[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

[David Spickett via lldb-commits]

================
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
 
 NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-    : NativeRegisterContextWindows(native_thread,
-                                   CreateRegisterInfoInterface(target_arch)) {}
+    : NativeRegisterContextRegisterInfo(
+          native_thread, CreateRegisterInfoInterface(target_arch)) {
+  // Currently, there is no API to query the maximum supported hardware
+  // breakpoints and watchpoints on Windows. The values set below are based
----------------
DavidSpickett wrote:

>  // on tests conducted on Windows 11 with Snapdragon Elite X hardware.

As in this is what the Windows header had set those defines to, or this is what you were able to use?

I remember this style from my MIPS days but there you could write to the registers and read them back to tell which slots were active. I don't know if that's a viable option here.

https://github.com/llvm/llvm-project/pull/108072