[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

i skimmed the patch, I didn't see anything that concerns me.  The fact that we can't query the number of hardware watchpoints/breakpoints means that this code will misbehave on other platforms where the numbers are different - we might have four hardware watchpoints, but you'll be limited to only setting one.  The hardware might only have 4 hardware breakpoints, so this code will let you set two additional ones which are ignored.  But I don't know what approach would be better here, given what Windows apparently provides.

I'll probably need to touch this new code a tiny bit once it's merged, for https://github.com/llvm/llvm-project/pull/105594 but there's no reason for Omair to do anything about that right now, I'm not ready to land my patches yet.

https://github.com/llvm/llvm-project/pull/108072