[Lldb-commits] [lldb] e0a93d3 - [lldb] Convert ProcessWindows.cpp to new Status API (NFC)

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 5 16:12:32 PDT 2024


Author: Adrian Prantl
Date: 2024-09-05T16:12:17-07:00
New Revision: e0a93d3505bf6b4c87e819db7a871e0ce4d4100c

URL: https://github.com/llvm/llvm-project/commit/e0a93d3505bf6b4c87e819db7a871e0ce4d4100c
DIFF: https://github.com/llvm/llvm-project/commit/e0a93d3505bf6b4c87e819db7a871e0ce4d4100c.diff

LOG: [lldb] Convert ProcessWindows.cpp to new Status API (NFC)

Added: 
    

Modified: 
    lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
    lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
index 6f2f6633021d34..9a5fcd88e12820 100644
--- a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
@@ -57,7 +57,7 @@ Status DebuggerThread::DebugLaunch(const ProcessLaunchInfo &launch_info) {
       "lldb.plugin.process-windows.secondary[?]",
       [this, launch_info] { return DebuggerThreadLaunchRoutine(launch_info); });
   if (!secondary_thread) {
-    result = Status(secondary_thread.takeError());
+    result = Status::FromError(secondary_thread.takeError());
     LLDB_LOG(log, "couldn't launch debugger thread. {0}", result);
   }
 

diff  --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
index 688b363bbb2db3..b25068dda53ffe 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -821,7 +821,7 @@ void ProcessWindows::OnDebuggerError(const Status &error, uint32_t type) {
     // If we haven't actually launched the process yet, this was an error
     // launching the process.  Set the internal error and signal the initial
     // stop event so that the DoLaunch method wakes up and returns a failure.
-    m_session_data->m_launch_error = error;
+    m_session_data->m_launch_error = error.Clone();
     ::SetEvent(m_session_data->m_initial_stop_event);
     LLDB_LOG(
         log,


        


More information about the lldb-commits mailing list