[Lldb-commits] [lldb] [lldb] Make deep copies of Status explicit (NFC) (PR #107170)

Thu Sep 5 12:47:03 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 4 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/5655

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build) failure: build (failure)
...
39.282 [446/72/460] Building CXX object tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/RegisterContextLinux_x86_64.cpp.o
39.379 [445/72/461] Building CXX object tools/lldb/source/Plugins/ObjectFile/ELF/CMakeFiles/lldbPluginObjectFileELF.dir/ObjectFileELF.cpp.o
39.394 [444/72/462] Building CXX object tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/RegisterContextNetBSD_x86_64.cpp.o
39.531 [443/72/463] Building CXX object tools/lldb/source/Plugins/Language/CPlusPlus/CMakeFiles/lldbPluginCPlusPlusLanguage.dir/CPlusPlusLanguage.cpp.o
39.562 [442/72/464] Building CXX object tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/RegisterInfos_x86_64_with_base_shared.cpp.o
39.685 [441/72/465] Building CXX object tools/lldb/source/Plugins/Platform/FreeBSD/CMakeFiles/lldbPluginPlatformFreeBSD.dir/PlatformFreeBSD.cpp.o
39.902 [440/72/466] Building CXX object tools/lldb/source/Plugins/Process/minidump/CMakeFiles/lldbPluginProcessMinidump.dir/MinidumpTypes.cpp.o
39.932 [439/72/467] Building CXX object tools/lldb/source/Plugins/Platform/Android/CMakeFiles/lldbPluginPlatformAndroid.dir/PlatformAndroid.cpp.o
40.205 [438/72/468] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunicationServerPlatform.cpp.o
40.294 [437/72/469] Building CXX object tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeProcessLinux.cpp.o
FAILED: tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeProcessLinux.cpp.o 
/usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/source/Plugins/Process/Linux -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Process/Linux -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/include -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/llvm/include -I/usr/include/python3.11 -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/llvm/../clang/include -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/../clang/include -I/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source -I/home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb/source -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeProcessLinux.cpp.o -MF tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeProcessLinux.cpp.o.d -o tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeProcessLinux.cpp.o -c /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1100:13: error: object of type 'lldb_private::Status' cannot be assigned because its copy assignment operator is implicitly deleted
      error =
            ^
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/include/lldb/Utility/Status.h:71:3: note: copy assignment operator is implicitly deleted because 'Status' has a user-declared move constructor
  Status(Status &&other) = default;
  ^
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1911:12: error: call to implicitly-deleted copy constructor of 'lldb_private::Status'
    return resume_result;
           ^~~~~~~~~~~~~
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/include/lldb/Utility/Status.h:71:3: note: copy constructor is implicitly deleted because 'Status' has a user-declared move constructor
  Status(Status &&other) = default;
  ^
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1917:12: error: call to implicitly-deleted copy constructor of 'lldb_private::Status'
    return step_result;
           ^~~~~~~~~~~
/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/include/lldb/Utility/Status.h:71:3: note: copy constructor is implicitly deleted because 'Status' has a user-declared move constructor
  Status(Status &&other) = default;
  ^
3 errors generated.
40.359 [437/71/470] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunicationServerCommon.cpp.o
40.429 [437/70/471] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/ProcessGDBRemoteLog.cpp.o
40.503 [437/69/472] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunication.cpp.o
40.588 [437/68/473] Building CXX object tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/HistoryUnwind.cpp.o
40.633 [437/67/474] Building CXX object tools/lldb/source/Plugins/Process/minidump/CMakeFiles/lldbPluginProcessMinidump.dir/RegisterContextMinidump_x86_32.cpp.o
40.668 [437/66/475] Building CXX object tools/lldb/source/Plugins/Process/minidump/CMakeFiles/lldbPluginProcessMinidump.dir/RegisterContextMinidump_ARM64.cpp.o
40.702 [437/65/476] Building CXX object tools/lldb/source/Plugins/Process/minidump/CMakeFiles/lldbPluginProcessMinidump.dir/RegisterContextMinidump_x86_64.cpp.o
40.736 [437/64/477] Building CXX object tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/HistoryThread.cpp.o
40.793 [437/63/478] Building CXX object tools/lldb/source/Plugins/Process/scripted/CMakeFiles/lldbPluginScriptedProcess.dir/ScriptedThread.cpp.o
40.798 [437/62/479] Building CXX object tools/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeFiles/lldbPluginAppleObjCRuntime.dir/AppleObjCRuntimeV2.cpp.o
40.905 [437/61/480] Building CXX object tools/lldb/source/Plugins/Process/minidump/CMakeFiles/lldbPluginProcessMinidump.dir/RegisterContextMinidump_ARM.cpp.o
41.006 [437/60/481] Building CXX object tools/lldb/source/Plugins/Platform/Linux/CMakeFiles/lldbPluginPlatformLinux.dir/PlatformLinux.cpp.o
41.019 [437/59/482] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteRegisterContext.cpp.o
41.387 [437/58/483] Building CXX object tools/lldb/source/Plugins/Process/elf-core/CMakeFiles/lldbPluginProcessElfCore.dir/RegisterContextPOSIXCore_mips64.cpp.o
41.410 [437/57/484] Building CXX object tools/lldb/source/Plugins/Process/elf-core/CMakeFiles/lldbPluginProcessElfCore.dir/RegisterContextLinuxCore_x86_64.cpp.o
41.437 [437/56/485] Building CXX object tools/lldb/source/Plugins/Process/scripted/CMakeFiles/lldbPluginScriptedProcess.dir/ScriptedProcess.cpp.o
41.468 [437/55/486] Building CXX object tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangExpressionParser.cpp.o
41.524 [437/54/487] Building CXX object tools/lldb/source/Plugins/Process/elf-core/CMakeFiles/lldbPluginProcessElfCore.dir/RegisterContextPOSIXCore_x86_64.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/107170