[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 4 13:23:59 PDT 2024
================
@@ -174,6 +176,85 @@ struct StatisticsOptions {
std::optional<bool> m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
+ : m_total_time(), m_impl_type(impl_type), m_name(name),
+ m_count(0) {}
+
+ std::string GetName() const { return m_name; };
+ double GetTotalTime() const { return m_total_time.get().count(); }
+
+ uint64_t GetSummaryCount() const {
+ return m_count.load(std::memory_order_relaxed);
+ }
+
+ StatsDuration &GetDurationReference() { return m_total_time; };
+
+ std::string GetSummaryKindName() const { return m_impl_type; }
+
+ llvm::json::Value ToJSON() const;
+
+
+ /// Basic RAII class to increment the summary count when the call is complete.
+ class SummaryInvocation{
+ public:
+ SummaryInvocation(std::shared_ptr<SummaryStatistics> summary_stats)
+ : m_stats(summary_stats),
+ m_elapsed_time(summary_stats->GetDurationReference()) {}
+ ~SummaryInvocation() { m_stats->OnInvoked(); }
+
+ /// Delete the copy constructor and assignment operator to prevent
+ /// accidental double counting.
+ /// @{
+ SummaryInvocation(const SummaryInvocation &) = delete;
+ SummaryInvocation &operator=(const SummaryInvocation &) = delete;
+ /// @}
+
+ private:
+ std::shared_ptr<SummaryStatistics> m_stats;
+ ElapsedTime m_elapsed_time;
+ };
+
+private:
+ void OnInvoked() noexcept {
+ m_count.fetch_add(1, std::memory_order_relaxed);
+ }
+ lldb_private::StatsDuration m_total_time;
+ std::string m_impl_type;
+ std::string m_name;
+ std::atomic<uint64_t> m_count;
+};
+
+typedef std::shared_ptr<SummaryStatistics> SummaryStatisticsSP;
----------------
clayborg wrote:
Move this above the `SummaryStatistics` class by doing:
```
class SummaryStatistics;
typedef std::shared_ptr<SummaryStatistics> SummaryStatisticsSP;
```
then use SummaryStatisticsSP in the class instead of manually typing `std::shared_ptr<SummaryStatistics>`
https://github.com/llvm/llvm-project/pull/102708
More information about the lldb-commits
mailing list