[Lldb-commits] [lldb] [lldb] Recurse through DW_AT_signature when looking for attributes (PR #107241)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 4 08:04:39 PDT 2024


================
@@ -50,7 +50,8 @@ class ElaboratingDIEIterator
     m_worklist.pop_back();
 
     // And add back any items that elaborate it.
-    for (dw_attr_t attr : {DW_AT_specification, DW_AT_abstract_origin}) {
+    for (dw_attr_t attr :
+         {DW_AT_specification, DW_AT_abstract_origin, DW_AT_specification}) {
----------------
Michael137 wrote:

Just from cursory reading it seems like `ElaboratingDIEIterator` is only useful for method DIEs currently? Which might be why no tests were affected here?

If you do need it as part of this patch then there's a couple of comments to fix up in `ElaboratingDIEIterator` that specifically talk about `DW_AT_specification`/`DW_AT_abstract_origin`

https://github.com/llvm/llvm-project/pull/107241


More information about the lldb-commits mailing list