[Lldb-commits] [lldb] [lldb][AIX] Taking Linux Host Info header's base for AIX (PR #106910)

[David Spickett via lldb-commits]

DavidSpickett wrote:

A couple of suggestions.

Perhaps you could reduce the PRs just to the files with the biggest differences on AIX, and include those changes in the PR. So that it is copying the file + making the AIX changes in one PR. Even if you have to add files that aren't used yet, we could wait to land the PR until we have reviewed the follow ups that do use them.

Maybe this is a good tactic for ptrace.h and Host.cpp, going by what you've said. Do one PR for each file so that everything is as clear as possible.

For the rest, a way to see whether one file for Linux and AIX would work would be to modify the existing file and add `#ifdef _AIX` everywhere a change is needed. Not as real code, but as a demonstration of exactly how awkward that would be to work with. You could post that as a draft PR and it would be very easy for us to see the additions, and recommend ways to refactor it if possible.

It doesn't even have to be buildable, as long as we get a rough idea of the changes.

(I do understand the instinct to split the initial copy-paste step into its own PR, I would have done the same, but in this case I think it makes it harder for us to assess the differences)

https://github.com/llvm/llvm-project/pull/106910