[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 4 01:12:19 PDT 2024
================
@@ -667,7 +669,22 @@ ConnectionStatus
ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#ifdef _WIN32
+ int64_t fd = -1;
+ if (!s.getAsInteger(0, fd)) {
+ // Assume we own fd.
+ std::unique_ptr<TCPSocket> tcp_socket =
+ std::make_unique<TCPSocket>((NativeSocket)fd, true, false);
+ m_io_sp = std::move(tcp_socket);
+ m_uri = s.str();
+ return eConnectionStatusSuccess;
+ }
+ if (error_ptr)
+ *error_ptr = Status::FromErrorStringWithFormat(
+ "invalid file descriptor: \"%s\"", s.str().c_str());
----------------
labath wrote:
```suggestion
*error_ptr = Status::FromErrorStringWithFormatv(
"invalid file descriptor: \"{0}\"", s);
```
https://github.com/llvm/llvm-project/pull/104238
More information about the lldb-commits
mailing list