[Lldb-commits] [lldb] [lldb][NFC] Move few static helpers to the class Socket and make them public (PR #106640)

[Dmitry Vasilyev via lldb-commits]

slydiman wrote:

> I don't think this is a good change.

What exactly is wrong here?

Is that code good duplicated in Socket.cpp and TCPSocket.cpp?
```
#if defined(_WIN32)
  bool success = closesocket(m_socket) == 0;
#else
  bool success = ::close(m_socket) == 0;
#endif
```

SetLastError(Status &error) is placed in Socket, but GetLastError() in TCPSocket. Is it ok?

https://github.com/llvm/llvm-project/pull/106640