[Lldb-commits] [lldb] [lldb] Add a callback version of TCPSocket::Accept (PR #106955)
Dmitry Vasilyev via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 2 04:19:01 PDT 2024
slydiman wrote:
> I don't like the idea of making Acceptor responsible for multiple ports for the same reason I did not want to do that for TCPSocket -- it's complicated and inflexible.
Note Acceptor is used ONLY in lldb-platform.cpp
We can use the Accept() for the second port in the second thread. Then it is enough to add TCPSocket::BreakAccept() or just use a dummy connection and don't change TCPSocket and Accptor at all.
But the common Accept() for both connections in the single thread looks much better.
https://github.com/llvm/llvm-project/pull/106955
More information about the lldb-commits
mailing list